Skip to content

Fix teardown error message in generated xUnit XML#2041

Merged
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom
gdyuldin:fix_xuint_teardown
Nov 2, 2016
Merged

Fix teardown error message in generated xUnit XML#2041
RonnyPfannschmidt merged 1 commit intopytest-dev:masterfrom
gdyuldin:fix_xuint_teardown

Conversation

@gdyuldin
Copy link
Copy Markdown
Contributor

@gdyuldin gdyuldin commented Nov 2, 2016

Thanks for submitting a PR, your contribution is really appreciated!

Here's a quick checklist that should be present in PRs:

  • Target: for bug or doc fixes, target master; for new features, target features;

Unless your change is trivial documentation fix (e.g., a typo or reword of a small section) please:

  • Make sure to include one or more tests for your change;
  • Add yourself to AUTHORS;
  • Add a new entry to CHANGELOG.rst
    • Choose any open position to avoid merge conflicts with other PRs.
    • Add a link to the issue you are fixing (if any) using RST syntax.
    • The pytest team likes to have people to acknowledged in the CHANGELOG, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.

It was "test setup failure" even error happens on test teardown.

It was "test setup failure" even error happens on test teardown.
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.002%) to 92.794% when pulling e2bb4f8 on gdyuldin:fix_xuint_teardown into e354455 on pytest-dev:master.

@RonnyPfannschmidt RonnyPfannschmidt merged commit 45b21fa into pytest-dev:master Nov 2, 2016
@RonnyPfannschmidt
Copy link
Copy Markdown
Member

well done thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants