Add note about not monkey-patching builtins#1986
Merged
RonnyPfannschmidt merged 2 commits intopytest-dev:masterfrom Oct 5, 2016
Merged
Add note about not monkey-patching builtins#1986RonnyPfannschmidt merged 2 commits intopytest-dev:masterfrom
RonnyPfannschmidt merged 2 commits intopytest-dev:masterfrom
Conversation
4 tasks
RonnyPfannschmidt
approved these changes
Oct 5, 2016
Member
RonnyPfannschmidt
left a comment
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
well done, please mention -s as well
|
|
||
| Be advised that it is not recommended to patch builtin functions such as ``open``, | ||
| ``compile``, etc., because it might break pytest's internals. If that's | ||
| unavoidable, passing ``--tb=native`` and/or ``--assert=plain`` might help althought |
Member
Author
|
(once this passes let's squash and merge please) |
Member
|
only trial fails |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1985