Skip to content

Show traceback during collection#1979

Merged
nicoddemus merged 2 commits intopytest-dev:masterfrom
nicoddemus:show-traceback-during-collection
Oct 5, 2016
Merged

Show traceback during collection#1979
nicoddemus merged 2 commits intopytest-dev:masterfrom
nicoddemus:show-traceback-during-collection

Conversation

@nicoddemus
Copy link
Copy Markdown
Member

@nicoddemus nicoddemus commented Oct 4, 2016 •
edited
Loading

Fixes #1976.

Here's the output:

master

______________________ ERROR collecting .tmp/test_foo.py ______________________
ImportError while importing test module 'C:\pytest\.tmp\test_foo.py'.
Original error message:
'cannot import name 'non_existing''
Make sure your test modules/packages have valid Python names.
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!

this PR

______________________ ERROR collecting .tmp/test_foo.py ______________________
ImportError while importing test module 'C:\pytest\.tmp\test_foo.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test_foo.py:1: in <module>
    import foo
foo.py:1: in <module>
    from bar import non_existing
E   ImportError: cannot import name 'non_existing'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!

this PR with -vv

______________________ ERROR collecting .tmp/test_foo.py ______________________
ImportError while importing test module 'C:\pytest\.tmp\test_foo.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
..\_pytest\python.py:415: in _importtestmodule
    mod = self.fspath.pyimport(ensuresyspath=importmode)
..\.env35\lib\site-packages\py\_path\local.py:650: in pyimport
    __import__(modname)
..\_pytest\assertion\rewrite.py:207: in load_module
    py.builtin.exec_(co, mod.__dict__)
test_foo.py:1: in <module>
    import foo
foo.py:1: in <module>
    from bar import non_existing
E   ImportError: cannot import name 'non_existing'
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!

nicoddemus
nicoddemus commented Oct 4, 2016
View reviewed changes
Comment thread testing/test_collection.py
import not_exists
""")
result = testdir.runpytest(p)
assert "__import__" not in result.stdout.str(), "too long traceback"
Copy link
Copy Markdown
Member Author

@nicoddemus nicoddemus Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was here to explicitly cut back the traceback from the error message, but unfortunately this makes it more difficult to find bugs.

nicoddemus
nicoddemus commented Oct 4, 2016
View reviewed changes
Comment thread _pytest/python.py
exc_info = ExceptionInfo()
if self.config.getoption('verbose') < 2:
exc_info.traceback = exc_info.traceback.filter(filter_traceback)
exc_repr = exc_info.getrepr(style='short') if exc_info.traceback else exc_info.exconly()
Copy link
Copy Markdown
Member Author

@nicoddemus nicoddemus Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to hard-code it to short because it is usually enough to track import problems and long may generate too much output during collection.

Copy link
Copy Markdown
Member

@RonnyPfannschmidt RonnyPfannschmidt Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please a comment in the code

Copy link
Copy Markdown
Member Author

@nicoddemus nicoddemus Oct 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, good point.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 4, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 92.909% when pulling a1d446b on nicoddemus:show-traceback-during-collection into fc02003 on pytest-dev:master.

@nicoddemus
Copy link
Copy Markdown
Member Author

nicoddemus commented Oct 4, 2016

No idea why the py35-trial failed, will investigate it later.

This was referenced Oct 4, 2016
Merged
Closed
@nicoddemus nicoddemus merged commit cf13355 into pytest-dev:master Oct 5, 2016
@nicoddemus nicoddemus deleted the show-traceback-during-collection branch October 5, 2016 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @coveralls @RonnyPfannschmidt