Improve error message when using pytest.skip at module level#1971
Closed
Nikratio wants to merge 1 commit intopytest-dev:masterfrom
Nikratio:patch-1
Closed
Improve error message when using pytest.skip at module level#1971Nikratio wants to merge 1 commit intopytest-dev:masterfrom Nikratio:patch-1
Nikratio wants to merge 1 commit intopytest-dev:masterfrom
Nikratio:patch-1
Conversation
As discussed in issue #1959.
nicoddemus
approved these changes
Sep 27, 2016
nicoddemus
requested changes
Sep 27, 2016
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks! Could you fix the tests please?
Contributor
Author
|
Sorry, that takes more time than I'm willing to invest into a trivial language fix. |
Member
|
No worries, thanks anyway! I will take it from here. |
Merged
Member
|
Superseded by #1975 (I rebased your commit, hope you don't mind) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current message can be read to imply that only the use of pytest.skip as top-level decorator is intentionally disabled, but that imperative test skipping is supposed to work.
Fixes issue #1959.