Remove implementation of __getslice__#1958
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Sep 24, 2016
Merged
Conversation
`__getslice__` has been Deprecated since Python 2.0 and is removed in Python 3. See https://docs.python.org/2/reference/datamodel.html#object.__getslice__ Unfortunately, Python 2 will still dispatch to `__getslice__` over `__getitem__`, See http://bugs.python.org/issue2041, which causes Warnings when running with `-3` in 2.7.
RonnyPfannschmidt
approved these changes
Sep 23, 2016
nicoddemus
approved these changes
Sep 24, 2016
Member
|
Merging because the failures are not related to the patch, will investigate why the failures are happening later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__getslice__has been Deprecated since Python 2.0 and is removed in Python 3. Seehttps://docs.python.org/2/reference/datamodel.html#object.__getslice__
Unfortunately, Python 2 will still dispatch to
__getslice__over__getitem__, Seehttp://bugs.python.org/issue2041, which causes Warnings when running with
-3in 2.7.