Fix importer call#1837
Closed
mbachry wants to merge 1 commit intopytest-dev:masterfrom
Closed
Conversation
Member
|
thanks, the fix is correct according to https://www.python.org/dev/peps/pep-0302/ i wonder if there is a simple way to test it how did you create the zip thats running pytest? |
Contributor
Author
|
I run tests from zips in my project (https://github.com/mbachry/exxo/), but here's a relatively simple way to reproduce, if you have access to Linux with Python 3.5: Not sure if it's easy to turn it into a proper unit test... |
Member
Contributor
Author
|
@nicoddemus Thanks. I'll leave it to you then. |
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Aug 22, 2016
nicoddemus
added a commit
to nicoddemus/pytest
that referenced
this pull request
Aug 22, 2016
Merged
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_filenameexpects full module name as a parameter. Currently pytest fails, if I run it with zip importer.