Fix off-by-one error with lines from request.node.warn#1806
Merged
nicoddemus merged 1 commit intopytest-dev:masterfrom Aug 15, 2016
Merged
Fix off-by-one error with lines from request.node.warn#1806nicoddemus merged 1 commit intopytest-dev:masterfrom
nicoddemus merged 1 commit intopytest-dev:masterfrom
Conversation
Member
|
Thanks @blueyed! Would you mind adding a quick |
The line numbers in `node.location` seem to be zero-based?!
blueyed
force-pushed
the
fix-off-by-one-error-with-warnings
branch
from
dc2b330 to
16cb5d0
Compare
Contributor
Author
|
Added a changelog entry. |
Member
|
Thanks @blueyed! 👍 |
Contributor
Author
|
The location being zero-based is a bit weird, isn't it - and I've noticed it being used wrong several times already (just with fschulze/pytest-pdb#2 now). Can this be addressed somehow, e.g. by providing some other interface, that is not zero-based? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line numbers in
node.locationseem to be zero-based?!