Improve overall CHANGELOG formatting and consistency for 3.0#1720
Improve overall CHANGELOG formatting and consistency for 3.0#1720The-Compiler merged 1 commit intopytest-dev:featuresfrom
Conversation
CHANGELOG.rst
Outdated
| pytest warning (`#1479`_). Thanks to `@The-Compiler`_ for the PR. | ||
|
|
||
| * removed support code for python 3 < 3.3 addressing (`#1627`_) | ||
| * Removed support code for Python versions < 3.3 addressing (`#1627`_). |
There was a problem hiding this comment.
I think it should explicitly say "Python 3 versions < 3.3" (or just "Python 3.0 - 3.2" or so?), otherwise this might imply we dropped 2.7 😉
There was a problem hiding this comment.
Also the parens in "addressing (#1234)" don't make any sense. I'm really not sure where this came from - maybe because older changelog entries said "[Added a] fix (...) for some issue" and then it got cargo-culted and also used like "Fixes (...)" and "addressing (...)". Anyways, we should get rid of it IMHO.
|
Seems like there are various places saying "for PR" and "for bug report", I didn't comment on all of them - maybe just add a "the" everywhere 😉 |
nicoddemus
force-pushed
the
changelog-formatting
branch
from
43ac5f7 to
4a763ac
Compare
Done!
Not at all, I appreciate the review. 😁 |
|
@The-Compiler could you merge if you don't have any other comments? I would like to get this in ASAP otherwise chances for conflicts with other PRs increases as time passes. 😁 |
|
And in it is! Thanks! |
|
😄 👍 |
3 participants
Tried to improve overall consistency and formatting of the CHANGELOG for 3.0. Suggestions are welcome!
Rules I tried to follow:
.;