Revert "fixtures: remove no longer needed special case in pytest_generate_tests"#14597
Merged
Merged
Conversation
…erate_tests`" This reverts commit d56b1af. Seems this is still needed for the indirect case. Revert and add a regression test for now; I might look into it more later.
bluetech
added
the
backport 9.1.x
psf-chronographer
Bot
added
the
bot:chronographer:provided
nicoddemus
approved these changes
Jun 15, 2026
Backport to 9.1.x: 💚 backport PR created✅ Backport PR branch: Backported as #14604 🤖 @patchback |
li-em
added a commit
to betolink/icechunk
that referenced
this pull request
Jun 15, 2026
Upstream bug: pytest-dev/pytest#14591 Fix: pytest-dev/pytest#14597 Still need an upstream release
bluetech
added a commit
that referenced
this pull request
Jun 15, 2026
…7723b8ce1875de809e82e4375e577df889afe83/pr-14597 [PR #14597/77723b8c backport][9.1.x] Revert "fixtures: remove no longer needed special case in `pytest_generate_tests`"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d56b1af.
Seems this is still needed for the indirect case. Revert and add a regression test for now; I might look into it more later.