Skip to content

Comments

doc: fix toml type of verbosity options in API reference#13906

Merged
bluetech merged 1 commit intopytest-dev:mainfrom
bluetech:doc-fix-verbosity-toml
Nov 10, 2025
Merged

doc: fix toml type of verbosity options in API reference#13906
bluetech merged 1 commit intopytest-dev:mainfrom
bluetech:doc-fix-verbosity-toml

Conversation

@bluetech
Copy link
Member

@bluetech bluetech commented Nov 9, 2025

Fix #13904.

@bluetech bluetech added the backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch label Nov 9, 2025
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Nov 9, 2025
@nicoddemus
Copy link
Member

nicoddemus commented Nov 10, 2025 •
edited
Loading

Perhaps the correct fix would be to change the option type to int?

pytest/src/_pytest/config/__init__.py

Line 1957 in adb3658

type="string",

Seems like it was just an oversight, unnoticed because of how ini options are treated.

@bluetech
Copy link
Member Author

bluetech commented Nov 10, 2025

Was my first thought, however I think it's a string because it needs to support "auto".

If in the future we support type expressions we can make it int | Literal["auto"] but until then we only have "string".

@nicoddemus
Copy link
Member

nicoddemus commented Nov 10, 2025

Ahh right, missed/forgot this bit:

pytest/src/_pytest/config/__init__.py

Lines 1933 to 1935 in adb3658

level = self.getini(ini_name)
if level == Config._VERBOSITY_INI_DEFAULT:
return global_level

@bluetech bluetech merged commit e826510 into pytest-dev:main Nov 10, 2025
33 checks passed
@patchback
Copy link

patchback bot commented Nov 10, 2025 •
edited
Loading

Backport to 9.0.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/9.0.x/e82651074d18a9a905d3beefb62bd7eb8196b6cd/pr-13906

Backported as #13915

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 10, 2025
@bluetech @patchback
Merge pull request #13906 from bluetech/doc-fix-verbosity-toml
908a0ba 
doc: fix toml type of verbosity options in API reference
(cherry picked from commit e826510)
@patchback patchback bot mentioned this pull request Nov 10, 2025
Merged
bluetech added a commit that referenced this pull request Nov 10, 2025
@bluetech
Merge pull request #13915 from pytest-dev/patchback/backports/9.0.x/e…
1edfc54 
…82651074d18a9a905d3beefb62bd7eb8196b6cd/pr-13906

[PR #13906/e8265107 backport][9.0.x] doc: fix toml type of verbosity options in API reference
@bluetech bluetech deleted the doc-fix-verbosity-toml branch November 10, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

backport 9.0.x apply to PRs at any point; backports the changes to the 9.0.x branch bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

verbosity_assertions needs a string in TOML, docs show int

2 participants

@bluetech @nicoddemus