fixtures: workaround PyPy bug which sometimes causes a KeyError crash during collection
#13442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Pierre-Sassoulas
approved these changes
May 26, 2025
Member
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Reading the bug reports was interesting
bluetech
force-pushed
the
reorder-items-pypy
branch
from
82ba788 to
aff35e6
Compare
Member
Author
|
Hmm some tests started failing because of |
Member
|
On modern setuptools its best to not run those tests Lets skip them if setuptools is modern |
…sh during collection Fix pytest-dev#13312.
bluetech
force-pushed
the
reorder-items-pypy
branch
from
aff35e6 to
1fdcf68
Compare
Member
Author
|
From what I can see we don't run coverage for pypy (probably too slow?), so the low patch coverage is expected. |
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13447 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 28, 2025
fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection (cherry picked from commit f59e1ad)
bluetech
added a commit
that referenced
this pull request
May 28, 2025
…59e1ad661832f18bce28a9522be2c6d37485d09/pr-13442 [PR #13442/f59e1ad6 backport][8.3.x] fixtures: workaround PyPy bug which sometimes causes a `KeyError` crash during collection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13312.