Skip to content

[PR #13343/9a7dbd8a backport][8.3.x] Add title and change spelling for use of approx with non-numerics #13347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicoddemus merged 1 commit into from
Apr 3, 2025
Merged

[PR #13343/9a7dbd8a backport][8.3.x] Add title and change spelling for use of approx with non-numerics #13347

nicoddemus merged 1 commit into from
Apr 3, 2025

Conversation

@patchback
Copy link

@patchback patchback bot commented Apr 3, 2025

This is a backport of PR #13343 as merged into main (9a7dbd8).

Closes #13218.

  • Added title to draw attention to the easily-missed information on non-numeric types for approx.
  • Changed spelling of all cases of "nonnumeric" to "non-numeric" within docstrings for clarity and consistency with .rst files.

@callummscott @patchback
Add title and change spelling for use of approx with non-numerics (#1…
4f11440 
…3343)

* Added title to draw attention to the easily-missed information on non-numeric types for approx.
* Changed spelling of all cases of "nonnumeric" to "non-numeric" within docstrings for clarity and consistency with .rst files.

Related to #13218

(cherry picked from commit 9a7dbd8)
@patchback patchback bot mentioned this pull request Apr 3, 2025
Merged
@nicoddemus nicoddemus enabled auto-merge (squash) April 3, 2025 12:54
@nicoddemus nicoddemus merged commit 75cf3e7 into 8.3.x Apr 3, 2025
29 checks passed
@nicoddemus nicoddemus deleted the patchback/backports/8.3.x/9a7dbd8a394bb47ee43be51d60ec3c4f4759789e/pr-13343 branch April 3, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicoddemus @callummscott