Duplicated parameters in parametrize marker#11489
Merged
Zac-HD merged 16 commits intopytest-dev:mainfrom Oct 8, 2023
Merged
Conversation
Zac-HD
reviewed
Oct 8, 2023
Zac-HD
approved these changes
Oct 8, 2023
4 tasks
1 task
Contributor
|
Hello! I think this PR might have broken something that used to work. We have a test downstream that parametrize values that include empty strings. The |
Member
|
Yep, that's a regression which we should fix! Would you mind opening a new issue for it? |
Contributor
|
Thanks for the quick reply! I opened #11563 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What's the problem this feature will solve?
The current behavior of pytest in handling duplicated values in parametrize can lead to confusion regarding the actual parameter values used in tests. This PR aims to address this issue by providing clear and unambiguous parameter identifiers.
[maintainer edit to link the issue: fixes #11456]
Solution Description
The proposed solution involves modifying the
make_unique_parameterset_idsmethod in thePython.pyclass. This change will ensure that unique identifiers are generated for ParameterSets, eliminating any confusion caused by duplicated values."{id}_{suffix}", wheresuffixis a numeric counter.