Skip to content

disallow config/session in from_parent api #6341

Closed

Description

@RonnyPfannschmidt

one important part of the from_parent api is to streamline the node-tree structure and constructors
as such we need to disallow session/config as parameters, so they can be fetched from the parent object in all cases

Activity

  1. added this to the 5.4 milestone on Dec 13, 2019
  2. added 2 commits that reference this issue on Dec 31, 2019
    fdcd45f
    4fcacde
  3. added 3 commits that reference this issue on Jan 15, 2020
    2958129
    a852ba7
    8ba0b7b
  4. RonnyPfannschmidt commented on Feb 5, 2020

    @RonnyPfannschmidt
    MemberAuthor

    fixed in the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

type: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelog

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions