-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Description
Reading this page https://docs.pypi.org/trusted-publishers/security-model/#considerations they mention:
Use a dedicated environment: GitHub Actions supports "environments," which can be used to isolate secrets to specific workflows. OIDC publishing doesn't use any pre-configured secrets, but a dedicated publish or deploy environment is a general best practice.
Dedicated environments allow for additional protections like required reviewers, which can be used to require manual approval for a workflow using the environment.
Seems like a good idea to segregate the deployment secrets to their own environment and add required reviewers (probably pytest core?) to better protect our releases.
I can try to set it up before the next release (#10869) if we agree.