Add buffer attribute to stdin stub

joguSD · joguSD · commit a152ea2dbbeb · 2016-08-24T16:26:34.000-07:00
diff --git a/AUTHORS b/AUTHORS
@@ -69,6 +69,7 @@ Javier Domingo Cansino
 Javier Romero
 John Towler
 Jon Sonesen
+Jordan Guymon
 Joshua Bronson
 Jurko Gospodnetić
 Justyna Janczyszyn
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -6,10 +6,12 @@
 * Improve error message when passing non-string ids to ``pytest.mark.parametrize`` (`#1857`_).
   Thanks `@okken`_ for the report and `@nicoddemus`_ for the PR.
 
-*
+* Add ``buffer`` attribute to stdin stub class ``pytest.capture.DontReadFromInput``
+  Thanks `@joguSD`_ for the PR.
 
 *
 
+.. _@joguSD: https://github.com/joguSD
 
 .. _#1857: https://github.com/pytest-dev/pytest/issues/1857
 
diff --git a/_pytest/capture.py b/_pytest/capture.py
@@ -455,6 +455,13 @@ def isatty(self):
     def close(self):
         pass
 
+    @property
+    def buffer(self):
+        if sys.version_info >= (3,0):
+            return self
+        else:
+            raise AttributeError('redirected stdin has no attribute buffer')
+
 
 def _readline_workaround():
     """
diff --git a/testing/test_capture.py b/testing/test_capture.py
@@ -662,6 +662,28 @@ def test_dontreadfrominput():
     f.close()  # just for completeness
 
 
+@pytest.mark.skipif('sys.version_info < (3,)', reason='python2 has no buffer')
+def test_dontreadfrominput_buffer_python3():
+    from _pytest.capture import DontReadFromInput
+    f = DontReadFromInput()
+    fb = f.buffer
+    assert not fb.isatty()
+    pytest.raises(IOError, fb.read)
+    pytest.raises(IOError, fb.readlines)
+    pytest.raises(IOError, iter, fb)
+    pytest.raises(ValueError, fb.fileno)
+    f.close()  # just for completeness
+
+
+@pytest.mark.skipif('sys.version_info >= (3,)', reason='python2 has no buffer')
+def test_dontreadfrominput_buffer_python2():
+    from _pytest.capture import DontReadFromInput
+    f = DontReadFromInput()
+    with pytest.raises(AttributeError):
+        f.buffer
+    f.close()  # just for completeness
+
+
 @pytest.yield_fixture
 def tmpfile(testdir):
     f = testdir.makepyfile("").open('wb+')

Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,12 @@`
`6`	`6`	* Improve error message when passing non-string ids to ``pytest.mark.parametrize`` (`#1857`_).
`7`	`7`	Thanks `@okken`_ for the report and `@nicoddemus`_ for the PR.
`8`	`8`
`9`		`-*`
	`9`	+* Add ``buffer`` attribute to stdin stub class ``pytest.capture.DontReadFromInput``
	`10`	+ Thanks `@joguSD`_ for the PR.
`10`	`11`
`11`	`12`	`*`
`12`	`13`
	`14`	`+.. _@joguSD: https://github.com/joguSD`
`13`	`15`
`14`	`16`	`.. _#1857: https://github.com/pytest-dev/pytest/issues/1857`
`15`	`17`