Testcase reports with a url attribute will now properly write this to junitxml

John Towler · John Towler · commit 1b259f70f3e0 · 2016-08-25T13:08:51.000-07:00
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -9,9 +9,12 @@
 * Add ``buffer`` attribute to stdin stub class ``pytest.capture.DontReadFromInput``
   Thanks `@joguSD`_ for the PR.
 
-*
+* Testcase reports with a url attribute will now properly write this to junitxml.
+  Thanks `@fushi`_ for the PR
+
 
 .. _@joguSD: https://github.com/joguSD
+.. _@fushi: https://github.com/fushi
 
 .. _#1857: https://github.com/pytest-dev/pytest/issues/1857
 
diff --git a/_pytest/junitxml.py b/_pytest/junitxml.py
@@ -102,6 +102,8 @@ def record_testreport(self, testreport):
         }
         if testreport.location[1] is not None:
             attrs["line"] = testreport.location[1]
+        if hasattr(testreport, "url"):
+            attrs["url"] = testreport.url
         self.attrs = attrs
 
     def to_xml(self):
diff --git a/testing/test_junitxml.py b/testing/test_junitxml.py
@@ -922,3 +922,28 @@ class Report(BaseReport):
         actual[k] = v
 
     assert actual == expected
+
+
+def test_url_property(testdir):
+    test_url = "http://www.github.com/pytest-dev"
+    path = testdir.tmpdir.join("test_url_property.xml")
+    log = LogXML(str(path), None)
+    from _pytest.runner import BaseReport
+
+    class Report(BaseReport):
+        longrepr = "FooBarBaz"
+        sections = []
+        nodeid = "something"
+        location = 'tests/filename.py', 42, 'TestClass.method'
+        url = test_url
+
+    test_report = Report()
+
+    log.pytest_sessionstart()
+    node_reporter = log._opentestcase(test_report)
+    node_reporter.append_failure(test_report)
+    log.pytest_sessionfinish()
+
+    test_case = minidom.parse(str(path)).getElementsByTagName('testcase')[0]
+
+    assert (test_case.getAttribute('url') == test_url), "The URL did not get written to the xml"

Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,8 @@ def record_testreport(self, testreport):`
`102`	`102`	`}`
`103`	`103`	`if testreport.location[1] is not None:`
`104`	`104`	`attrs["line"] = testreport.location[1]`
	`105`	`+ if hasattr(testreport, "url"):`
	`106`	`+ attrs["url"] = testreport.url`
`105`	`107`	`self.attrs = attrs`
`106`	`108`
`107`	`109`	`def to_xml(self):`