Temporary fix to update_all (Immediate bug fix)#2455
Merged
WebReflection merged 5 commits intopyscript:mainfrom Feb 25, 2026
Merged
Temporary fix to update_all (Immediate bug fix)#2455WebReflection merged 5 commits intopyscript:mainfrom
WebReflection merged 5 commits intopyscript:mainfrom
Conversation
WebReflection
approved these changes
Feb 25, 2026
Contributor
WebReflection
left a comment
WebReflection
left a comment
There was a problem hiding this comment.
great simplification, thank you!
Contributor
|
@iliketocode2 do you have access rights to merge your own PRs after approval? If not, @ntoll , should we grant him that possibility? |
Contributor
Author
|
I do not yet have permission to merge my own PR's after approval. |
Member
|
Dammit - I look away for a moment and there you are, submitting PRs, having them reviewed and approved... and now also merged! 🤣 Bravo! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
update_allmethod inElementCollectionto use theupdatemethod exclusively. It is meant to be a temporary and immediate bug fix before a further (possible) refactor occurs.See discussion #2453 for more details and the subsequent conversation.
Changes
ElementCollection.update_allincore/src/stdlib/pyscript/web.pyto explicitly accept classes and style arguments.setattrloop with a direct call toelement.update(classes=classes, style=style, **kwargs)update_allupdate_all:test_update_all_classes_parameter,test_update_all_style_parameter, andtest_update_all_combined.Changes in
pyscript/docscan be seen in this PR:Checklist
make buildworks locally.