Updated polyscript wth latest MicroPython#2454
Conversation
|
@ntoll there are 2 regressions (or one regression and one changed behavior) in MicroPython:
I already informed @dpgeorge about both, let's see if we can have at least |
|
@WebReflection ack on that. Let's hold until @dpgeorge gets back to us about both issues. 👍 |
|
Both of those things are bugs, and now fixed by the new release here: https://www.npmjs.com/package/@micropython/micropython-webassembly-pyscript/v/1.28.0-preview-233 |
That was failing because I'm not sure how Pyodide handles that particular case. What if Well, we can have that discussion another time. For now, it should be back to the old behaviour, where all JsProxy objects are considered true. |
fe47b4a to
cc37205
Compare
cc37205 to
87c9d62
Compare
It is also very possible the test case in point was plain wrong ... the surprise was a change of behavior but the detail is that I was never asking the length of that object, I was trying to retrieve the ability to iterate via
it's one of those weird PL translations:
That means, in Python On the other side, if the reference is iterable, it should never return Again, I've changed already the test in case because it was weird anyway, tested from a Python world, still I think it's important that these semantics are preserved per each PL world/semantic meaning. |
|
@ntoll and @dpgeorge , that being said, I've already updated all the things and CI is happy now, I think we should consider publishing PyScript with latest MicroPython as it is and see what people think, discover, or create with all the latest great features that such preview version brought to the Web plate ... agreed? |
|
this has been published on npm as:
|
Maybe we need to add a special case for this, because currently |
Description
This MR brings in latest MicroPython with all its new features: pyscript/polyscript#172
Changes
Checklist
make buildworks locally.