Conversation
…t path (previously would throw an exception).
WebReflection
approved these changes
Feb 5, 2026
Contributor
WebReflection
left a comment
WebReflection
left a comment
There was a problem hiding this comment.
I always "panic" a bit when I see import js as I need to be sure it's not doing main thread things only ... I would've written that as:
from js import consolebut at the same time, this is more a nit you can ignore than a blocker: approved!
ntoll
force-pushed
the
css-class-removal-refinement
branch
from
2edc66a to
0f118d3
Compare
Member
Author
|
I've fixed the nit. Thanks for the spot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
removemethod for CSS classes is now more forgiving - allowing you to attempt to remove non-existent classes without throwing an exception. It now logs a warning.Changes
Updated the
removemethod. Added a check for this change of behaviour to an existing unit test.Checklist
make buildworks locally.