-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Single-quoted keys make pyscript fail silently. (TOML) #2372
Copy link
Copy link
Closed
Labels
type: bugSomething isn't workingSomething isn't workingtype: featureNew feature or requestNew feature or request
Description
Checklist
- I added a descriptive title
- I searched for other issues and couldn't find a solution or duplication
- I already searched in Google and didn't find any good information or help
What happened?
When using config.toml with something like this:
[files]
'file.py' = ""Pyscript won't finish loading itself.
Something similar was discussed in #1700, but the main two differences are:
- It's a valid TOML syntax
- It fails silently - no error message are visible in the dev console.
What could happen instead:
- Pyscript parses the config file correctly (best scenario)
- Pyscript throws an error indicating "malfolmed" config (quite good scenario)
- The documentation indicates that supported TOML syntax is only a subset (quite bad solution - what subset?)
What browsers are you seeing the problem on? (if applicable)
No response
Console info
[Literarly empty dev console, it's less empty when pyscript loads properly.]
Additional Context
After investigating this a bit more, I discoverd that pyscript uses two different TOML parsers for loading the TOML files:
tomlify-j0.4- apparently implementation ofTOML v0.4, quite old and it's unclear to me whether it supports single quoted keys.basic-toml- it's used bypolyscriptand seems to implement a custom subset of TOML.
I don't know which one of them is the culprit, but wouldn't it better to switch to one, but newer library?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: bugSomething isn't workingSomething isn't workingtype: featureNew feature or requestNew feature or request