Conversation
frgfm
added
type: improvement
fe51
previously approved these changes
Oct 10, 2022
fe51
self-requested a review
October 11, 2022 16:06
fe51
reviewed
Oct 11, 2022
| lon: Optional[float] = Field(..., gt=-180, lt=180, example=4.514880) | ||
| elevation: Optional[float] = Field(..., gt=0.0, lt=10000, example=1582) | ||
| yaw: Optional[float] = Field(..., ge=0, le=360, example=110) | ||
| azimuth: Optional[float] = Field(..., ge=0, le=360) |
fe51
previously approved these changes
Oct 11, 2022
Member
Author
|
No need to review until I get the unittests to work :) |
Member
|
Ho okay sorry, thought it was done ! :) |
Codecov Report
@@ Coverage Diff @@
## master #219 +/- ##
==========================================
+ Coverage 94.07% 94.08% +0.01%
==========================================
Files 47 47
Lines 1282 1285 +3
==========================================
+ Hits 1206 1209 +3
Misses 76 76
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
Author
|
Now it's all good :) |
This was referenced Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following modifications:
Any feedback is welcome!