Codecov Report

Merging #215 (f37847c) into master (5df89ed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #215   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files          47       47           
  Lines        1285     1285           
=======================================
  Hits         1209     1209           
  Misses         76       76           

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

You are right, it has to be integrated to unittests !
As this is a bug for which we don't have a theoretical explanation, I made an update of the dummy creds in the light of what the current fix allows (hence including special characters in the frame of the creds at the origin of the bug)

Can you confirm that those unittests fail without your modification? (if that's the case, we can move forward)

ping @fe51 🙏

@frgfm tested updated, we can merge !

Did you manage to get the client unittests to run? Because the job is failing, and flake8 isn't happy :/

Okay, I have been able to run tests locally and solve issues !

I think this is ready to merge @frgfm, finally :D

As a reminder, the problems encountered were :

• login must fit regular expression imposed in base.py

login: str = Field(..., min_length=3, max_length=50, regex="^[a-zA-Z0-9_-]+$", example="JohnDoe")

• Did not managed to pass a double $$ in password var to docker-compose env variable salthough doc was suggesting it would work with singles quotes ' ' (here and there)