Skip to content

feat: Added admin scopes to installation routes#120

Merged
frgfm merged 1 commit into
masterfrom
installation-scope
Mar 18, 2021
Merged

feat: Added admin scopes to installation routes#120
frgfm merged 1 commit into
masterfrom
installation-scope

Conversation

@frgfm

@frgfm frgfm commented Mar 15, 2021

Copy link
Copy Markdown
Member

Following up on #45, this PR introduces the following modifications:

  • added admin scope to installation GET routes

Any feedback is welcome!

@frgfm frgfm added this to the 0.1.2 milestone Mar 15, 2021
@frgfm
frgfm requested review from a team, fe51, florianriche, jean-pasquier and martin1tab March 15, 2021 23:15
@frgfm frgfm self-assigned this Mar 15, 2021
@frgfm frgfm mentioned this pull request Mar 15, 2021
9 tasks
@codecov

codecov Bot commented Mar 15, 2021

Copy link
Copy Markdown

Codecov Report

Merging #120 (e618862) into master (a139a8c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #120   +/-   ##
=======================================
  Coverage   88.31%   88.31%           
=======================================
  Files          27       27           
  Lines         787      787           
=======================================
  Hits          695      695           
  Misses         92       92           
Flag Coverage Δ
unittests 88.31% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/api/routes/installations.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a139a8c...e618862. Read the comment docs.

@frgfm
frgfm merged commit 301965c into master Mar 18, 2021
@frgfm
frgfm deleted the installation-scope branch March 18, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants