feat: Added proper scopes to media routes#118
Merged
Merged
Conversation
frgfm
requested review from
a team,
fe51,
florianriche,
jean-pasquier and
martin1tab
March 15, 2021 23:05
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 27 27
Lines 787 787
=======================================
Hits 695 695
Misses 92 92
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
fe51
approved these changes
Mar 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #45, this PR introduces the following modifications:
Any feedback is welcome!
Note: I think there is an issue with our unittests regarding Security/get_current_access. When I test it manually, the changes from this PR do work. But this means that the current unittests should fail (because the default current access doesn't have admin scope). I'll open an issue about this #119