REF: Make CRS methods inheritable#902
Merged
snowman2 merged 1 commit intopyproj4:masterfrom Aug 17, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
+ Coverage 95.29% 95.35% +0.06%
==========================================
Files 21 21
Lines 1680 1724 +44
==========================================
+ Hits 1601 1644 +43
- Misses 79 80 +1
Continue to review full report at Codecov.
|
snowman2
force-pushed
the
build_crs
branch
3 times, most recently
from
6f642d4 to
fb4133a
Compare
This was referenced Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
history.rstfor all changes andapi/*.rstfor new APINotes:
from_*methods were changed to bypass the__init__method. It also validates that it creates the expected type (Idea from CRS classmethods changed to staticmethods #847 (comment)).CRS. The reason for this is because the type of the CRS returned from that type is not guaranteed to always be the type of the original CRS.