Skip to content

made enumeration lookup case insensitive#302

Merged
snowman2 merged 2 commits intopyproj4:masterfrom
snowman2:case_insensitive_enum
May 17, 2019
Merged

made enumeration lookup case insensitive#302
snowman2 merged 2 commits intopyproj4:masterfrom
snowman2:case_insensitive_enum

Conversation

@snowman2
Copy link
Copy Markdown
Member

@snowman2 snowman2 commented May 16, 2019

@snowman2 snowman2 force-pushed the case_insensitive_enum branch from c1f3225 to 9ade693 Compare May 16, 2019 01:13
Copy link
Copy Markdown
Contributor

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@snowman2
Copy link
Copy Markdown
Member Author

The strange thing is that the Windows build is not finding aenum. It's a shame as it is nice to have.

@jorisvandenbossche
Copy link
Copy Markdown
Contributor

The strange thing is that the Windows build is not finding aenum. It's a shame as it is nice to have.

It might be related to the pip install command (as there are for sure universal wheels for all platforms/python versions). The --no-index maybe?

@snowman2
Copy link
Copy Markdown
Member Author

The --no-index maybe?

Maybe, definitely worth looking into.

@snowman2
Copy link
Copy Markdown
Member Author

I didn't look at the full logs earlier - the failure was after the tests. Thanks for the tip @jorisvandenbossche!

@snowman2 snowman2 merged commit 69c48b3 into pyproj4:master May 17, 2019
@hobu
Copy link
Copy Markdown

hobu commented Jun 3, 2019

Can aenum be made optional? It causes some complications for packagers https://lists.debian.org/debian-gis/2019/06/msg00000.html

@snowman2 snowman2 deleted the case_insensitive_enum branch September 2, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make enums case insensitive

3 participants