made TransformDirection enum string based; added _missing_ method to raise error when value missing#300
Conversation
|
Looks like |
|
@jswhit, that sounds good. I will go ahead and merge. Would you be okay with me making a release as well (minus uploading to pypi)? |
|
I was thinking about making a release along with PROJ 6.1.0 release on May 15. Is that okay? Or would you prefer to be able to review everything before then (which is fine - no rush on my end)? |
I think that does not make much sense. I think waiting until you are ready would be the better decision in this case. Better to have a good review before the release since there isn't a rush. I was just getting ahead of myself there. |
|
|
||
| #: Forward direction | ||
| FORWARD = 1 | ||
| FORWARD = "FORWARD" |
There was a problem hiding this comment.
Small remark: we could also opt for lower case? (that might be a little bit nicer in user code (transform(..., direction='inverse') vs transform(..., direction='INVERSE'))
Just a remark, no strong preference either way!
There was a problem hiding this comment.
I thought about doing that, and decided that the upper case version is consistent with the upper case WKT enum strings.
There was a problem hiding this comment.
Yep, on the other hand, WKT is an existing abbreviation that is written in upper case, while forward/inverse are normal words.
There was a problem hiding this comment.
That's true. What would be nice is a case insensitive solution.
There was a problem hiding this comment.
That would preserve past behavior as that's how I had it before.
3 participants
Addresses #298 and #288 (comment)
Uses idea from #288 (comment) to better handle invalid input.
@jorisvandenbossche