Genericize OIDC templates, forms and views #15143
Merged
Conversation
2 tasks
woodruffw
approved these changes
Jan 5, 2024
miketheman
approved these changes
Jan 5, 2024
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
Nice work, took me a bit to read through and figure this out.
A couple of questions and notes inline - nothing particularly blocking.
miketheman
approved these changes
Jan 5, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the OIDC templates, forms and views more "generic" and less GitHub-specific. This is a precursor to the fix for #13551 (which I have drafted). This PR doesn't introduce any functional changes.
After this, we should get #14063 merged as well, and then we can begin adding other trusted publishers.
(cc @woodruffw)