Add yank reason to release history page#15115
Merged
miketheman merged 6 commits intopypi:mainfrom Feb 12, 2024
Merged
Conversation
woodruffw
reviewed
Jan 31, 2024
miketheman
requested changes
Feb 7, 2024
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
Looking good - awaiting the final change for the callout block styling.
miketheman
added
UX/UI
Contributor
Author
|
Yanked reason styling updated. |
woodruffw
approved these changes
Feb 11, 2024
miketheman
approved these changes
Feb 12, 2024
Member
|
@cofiem Thanks for working through this! I manually purged one example page to confirm, and it looks good: https://pypi.org/project/Red-DiscordBot/#history The rest of pages should naturally expire from cache in a day, or as they yank/unyank their HTML will be refreshed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the yank reason to the release history page.
Notes:
@include ellipsis;to ensure the yank reason is always restricted to one line.Reason this release was yanked:with the screen reader-only class, because it's obvious looking at the release box, but a screenreader might need some context.Closes #9837