Show yanked reason on release page#15078
Merged
miketheman merged 4 commits intopypi:mainfrom Dec 19, 2023
Merged
Conversation
miketheman
reviewed
Dec 18, 2023
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
Generally good - had a question about the color choice.
miketheman
approved these changes
Dec 19, 2023
Member
miketheman
left a comment
miketheman
left a comment
There was a problem hiding this comment.
Excellent, looks great! Thanks!
Member
|
Keep in mind that due to caching, this may not appear on existing yanked releases until their cache expires. |
Member
|
We might want to think about finding a way to render links when they are present in the yank reason, e.g. https://pypi.org/project/pip/21.2/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases that have been yanked can include a reason. This reason is not currently displayed on the PyPI website.
For releases that have been yanked, show the yanked reason in a callout box on the project's release page.
Closes #9837
See screenshot for an example.
