Wrap tokenlist in list if self.resultsName is present#324
Merged
ptmcg merged 2 commits intopyparsing:masterfrom Oct 29, 2021
Merged
Wrap tokenlist in list if self.resultsName is present#324ptmcg merged 2 commits intopyparsing:masterfrom
self.resultsName is present#324ptmcg merged 2 commits intopyparsing:masterfrom
Conversation
Contributor
Author
|
I am not at familiar with this library, so the commit message is a bad attempt at me trying to explain the change. 😅 If you end up using this PR please edit the title to something that makes more sense. |
Member
|
Looking at this now, thanks so much for doing this research!!! |
Member
|
Ok, I would really like to use your PR so you get your contributor credits. But the change needs to work with and without results names, and with and without asPythonDict=True. I'm testing the different permutations, and will send you a fix to correct your PR. |
ptmcg
reviewed
Oct 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to have been a small behavior change to
class Dict()whenasdictwas added. This restores the branch that was lost (self.resultsNameis present).3c495db#diff-651b49e05968bd7f42614f05b7e9d94b30f52db27eb692ce20ef87e9799c624f