@@ -38,6 +38,7 @@ def test_download_wheel_bad_output(mocker, for_py_version, session_app_data) ->
3838 distribution = "setuptools"
3939 p_open = mocker .MagicMock ()
4040 mocker .patch ("virtualenv.seed.wheels.acquire.Popen" , return_value = p_open )
41+ mocker .patch ("virtualenv.seed.wheels.acquire.verify_wheel_digest" )
4142 p_open .communicate .return_value = "" , ""
4243 p_open .returncode = 0
4344
@@ -58,6 +59,19 @@ def test_download_wheel_bad_output(mocker, for_py_version, session_app_data) ->
5859 assert result .path == embed .path
5960
6061
62+ def test_download_wheel_not_found_raises (mocker , for_py_version , session_app_data ) -> None :
63+ """download_wheel must raise a clear error rather than crash when no wheel can be identified at all."""
64+ p_open = mocker .MagicMock ()
65+ mocker .patch ("virtualenv.seed.wheels.acquire.Popen" , return_value = p_open )
66+ p_open .communicate .return_value = "" , ""
67+ p_open .returncode = 0
68+ as_path = mocker .MagicMock ()
69+ as_path .iterdir .return_value = []
70+
71+ with pytest .raises (RuntimeError , match = "could not find downloaded wheel" ):
72+ download_wheel ("setuptools" , None , for_py_version , [], session_app_data , as_path , os .environ )
73+
74+
6175def test_download_fails (mocker , for_py_version , session_app_data ) -> None :
6276 p_open = mocker .MagicMock ()
6377 mocker .patch ("virtualenv.seed.wheels.acquire.Popen" , return_value = p_open )
@@ -94,13 +108,51 @@ def test_download_wheel_python_io_encoding(mocker, for_py_version, session_app_d
94108 mock_popen .return_value .communicate .return_value = "Saved a-b-c.whl" , ""
95109 mock_popen .return_value .returncode = 0
96110 mocker .patch ("pathlib.Path.absolute" , return_value = Path ("a-b-c.whl" ))
111+ mocker .patch ("virtualenv.seed.wheels.acquire.verify_wheel_digest" )
97112
98113 download_wheel ("pip" , "==1" , for_py_version , [], session_app_data , "folder" , os .environ .copy ())
99114
100115 env = mock_popen .call_args [1 ]["env" ]
101116 assert env ["PYTHONIOENCODING" ] == "utf-8"
102117
103118
119+ def test_download_wheel_verifies_digest (mocker , for_py_version , session_app_data ) -> None :
120+ """download_wheel must reject a wheel whose bytes do not match PyPI's published digest."""
121+ mock_popen = mocker .patch ("virtualenv.seed.wheels.acquire.Popen" )
122+ mock_popen .return_value .communicate .return_value = "Saved a-b-c.whl" , ""
123+ mock_popen .return_value .returncode = 0
124+ mocker .patch ("pathlib.Path.absolute" , return_value = Path ("a-b-c.whl" ))
125+ verify = mocker .patch (
126+ "virtualenv.seed.wheels.acquire.verify_wheel_digest" ,
127+ side_effect = RuntimeError ("digest mismatch" ),
128+ )
129+
130+ with pytest .raises (RuntimeError , match = "digest mismatch" ):
131+ download_wheel ("pip" , "==1" , for_py_version , [], session_app_data , "folder" , os .environ .copy ())
132+
133+ assert verify .call_count == 1
134+
135+
136+ @pytest .mark .parametrize ("env_var" , ["PIP_INDEX_URL" , "PIP_EXTRA_INDEX_URL" , "PIP_INDEX" ])
137+ def test_download_wheel_skips_digest_check_for_custom_index (mocker , for_py_version , session_app_data , env_var ) -> None :
138+ """A configured custom index may legitimately serve a same-named wheel PyPI never built."""
139+ mock_popen = mocker .patch ("virtualenv.seed.wheels.acquire.Popen" )
140+ mock_popen .return_value .communicate .return_value = "Saved a-b-c.whl" , ""
141+ mock_popen .return_value .returncode = 0
142+ mocker .patch ("pathlib.Path.absolute" , return_value = Path ("a-b-c.whl" ))
143+ verify = mocker .patch (
144+ "virtualenv.seed.wheels.acquire.verify_wheel_digest" ,
145+ side_effect = RuntimeError ("would have rejected a legitimate wheel" ),
146+ )
147+ env = os .environ .copy ()
148+ env [env_var ] = "https://example.com/simple"
149+
150+ result = download_wheel ("pip" , "==1" , for_py_version , [], session_app_data , "folder" , env )
151+
152+ assert result .name == "a-b-c.whl"
153+ assert verify .call_count == 0
154+
155+
104156@pytest .fixture
105157def downloaded_wheel (mocker ):
106158 wheel = Wheel .from_path (Path ("setuptools-0.0.0-py2.py3-none-any.whl" ))
0 commit comments