Skip to content

Remove --skip-existing support for non-PyPI indices#1253

Merged
sigmavirus24 merged 1 commit intopypa:mainfrom
sigmavirus24:bug/1251
Jul 13, 2025
Merged

Remove --skip-existing support for non-PyPI indices#1253
sigmavirus24 merged 1 commit intopypa:mainfrom
sigmavirus24:bug/1251

Conversation

@sigmavirus24
Copy link
Copy Markdown
Member

@sigmavirus24 sigmavirus24 commented Jun 18, 2025

Closes #1251


Still needs:

  • Automated testing because it's not that hard, I just tdon't have time to write them right now

@sigmavirus24 sigmavirus24 requested a review from woodruffw June 18, 2025 02:17
@sigmavirus24 sigmavirus24 force-pushed the bug/1251 branch 2 times, most recently from b05fdbf to 708defe Compare June 18, 2025 12:47
Comment thread twine/commands/upload.py
Comment thread twine/commands/upload.py
@sigmavirus24 sigmavirus24 force-pushed the bug/1251 branch 2 times, most recently from ce05a03 to c388900 Compare June 19, 2025 00:04
@sigmavirus24 sigmavirus24 changed the title WIP: Remove --skip-existing support for non-PyPI indices Remove --skip-existing support for non-PyPI indices Jun 24, 2025
@sigmavirus24 sigmavirus24 marked this pull request as ready for review June 24, 2025 14:10
@sigmavirus24
Copy link
Copy Markdown
Member Author

@woodruffw can you take a look at this when you have a chance?

@woodruffw
Copy link
Copy Markdown
Member

Sure, taking a look now. Sorry for the delay, this slipped my mind earlier.

Copy link
Copy Markdown
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no concerns 🙂

@sigmavirus24 sigmavirus24 merged commit c1c02d1 into pypa:main Jul 13, 2025
24 checks passed
@sigmavirus24 sigmavirus24 deleted the bug/1251 branch July 13, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Artifactory overwrite message changed?

3 participants