Skip to content

Comments

[CI] Attempt to solve problems with cygwin in the CI#4832

Merged
abravalheri merged 4 commits intopypa:mainfrom
abravalheri:issue-4831
Feb 17, 2025
Merged

[CI] Attempt to solve problems with cygwin in the CI#4832
abravalheri merged 4 commits intopypa:mainfrom
abravalheri:issue-4831

Conversation

@abravalheri
Copy link
Contributor

Summary of changes

Closes #4831

Pull Request Checklist

@abravalheri abravalheri changed the title Attempt to solve problems with cygwin in the CI [CI] Attempt to solve problems with cygwin in the CI Feb 17, 2025
@abravalheri abravalheri marked this pull request as ready for review February 17, 2025 14:54
@abravalheri
Copy link
Contributor Author

abravalheri commented Feb 17, 2025

/cc @lazka, @jaraco

According to the investigation described in #4831, it seems that this approach solves the problem.

Please let me know if there is any special requirement/reason so that we need to use the downstream cygwin package instead.

run: |
git config --global --add safe.directory "$(cygpath -u "$GITHUB_WORKSPACE")" # workaround for #3408
tox
git config --global --add safe.directory "$(cygpath -u "${{ github.workspace }}")" # workaround for #3408
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git config --global --add safe.directory '*' should also work, but ymmv

@lazka
Copy link
Contributor

lazka commented Feb 17, 2025

My guess on what the problem is: #4831 (comment)

so this lgtm

@abravalheri
Copy link
Contributor Author

Thank you very much for the review.

@abravalheri abravalheri merged commit ba24375 into pypa:main Feb 17, 2025
24 checks passed
@abravalheri abravalheri deleted the issue-4831 branch February 17, 2025 18:40
@DWesl
Copy link
Contributor

DWesl commented Feb 18, 2025

Please let me know if there is any special requirement/reason so that we need to use the downstream cygwin package instead.

The only Cygwin Python packages I know to make changes from PyPI source releases are those that build C extension modules from source (Cython, cffi, pythran, pybind11), as the maintainer considers shared libraries exporting only a single function indicative of a failure in the build process.

jaraco pushed a commit to pypa/distutils that referenced this pull request Feb 23, 2025
@jaraco jaraco mentioned this pull request Feb 23, 2025
2 tasks
clrpackages pushed a commit to clearlinux-pkgs/pypi-setuptools that referenced this pull request Mar 21, 2025
…version 77.0.1

Anderson Bravalheri (41):
      Export `PyInit_pkg` for `pkg.__init__` instead of `PyInit___init__`
      Prevent deprecated license classifiers from being written to core metadata
      Improve message in warning
      Use a more explicit method for preserving static-ness of classifiers
      Add news fragment
      Keep warning about license classifiers but raise an error if license expression is used
      Update newsfragment
      Use a better docs URL for warning
      Ensure _apply_pyproject sets field on dist.metadata object not on dist
      Update URL for warning
      Fix bypassed assertion in tests
      Attempt to fix sphinx warnings
      Attempt to improve display of pep links
      Add deprecation warning for project.license as a table in pyproject.toml
      Adequate tests to warning
      Add news fragment
      Ensure _finalize_license_expression preserve "static-ness"
      Ensure PEP 639 implementation plays nicely with PEP 643
      Improve license/license_expression relationship with 'dynamic' in pyproject.toml
      Add comments and test about dynamic x license_files
      Apply suggestions from code review
      Add minimal validation to license glob patterns
      Skip _finalize_license_files in test without source tree
      Add test for unmatch license-files pattern
      Add news fragment
      Avoid path separator problem in doctest on windows
      Validate license-files glob patterns individually
      [CI] Address problems with `cygwin` (pypa/setuptools#4832, pypa/distutils#328)
      Fix new mandatory configuration field for RTD (jaraco/skeleton#159)
      Small adjustments and fixes to make tests work
      Add thanks note to newsfragment
      Enable 'edit this page' button in the docs
      Update vendored copy of wheel
      Add news fragment
      Add news fragment for PEP 639 marking as 'breaking'
      Update URL in warning
      Bump version: 76.1.0 → 77.0.0
      Manually fix news fragment entries
      Add news fragments
      Change news fragment name to imply patch version bump
      Bump version: 77.0.0 → 77.0.1

Avasam (16):
      Merge typeshed's `setuptools._distutils` annotations
      Make sdist.metadata_check an actual boolean
      Add make_archive overloads
      Fix impossible _Env import
      Fix runtime bound typevars
      Fix deprecated
      Fix TypeAlias import
      from __future__ import annotations
      from __future__ import annotations
      Missing noqa
      Select Ruff rules for modern type annotations (jaraco/skeleton#160)
      Consistent import sorting (isort) (jaraco/skeleton#157)
      Fix failing test
      Fix condition post-merge
      Reduce Ruff configs that duplicates upstream after skeleton merge
      Restore missing public symbols after compilers move

DWesl (12):
      ENH: Don't add system library directories to rpath
      ENH: Drop LIBDIR from RPATH only if starting with /usr/lib.
      TST: Get all tests passing on Cygwin.
      STY: Apply suggestions from CI running black
      CI: Install a library to link to on Cygwin
      TST: Try testing rpath with non-FHS library dir
      TST: Use different library file for link test
      DBG: Print ELF headers of extension on Linux.
      TST: Clarify RPATH testing asserts.
      FIX: Sort library names by length to avoid links
      BUG: Resolve links before sorting library paths.
      TST: Remove the part of the new test checking old behavior.

Jason R. Coombs (37):
      👹 Feed the hobgoblins (delint).
      Move compiler implementations into their own package.
      Rename classes and add compatibility shims.
      Move compiler execeptions to their package.
      In compiler package, rely on compiler errors.
      Move compiler tests to the compilers package.
      Direct tests to the new names
      Add news fragment.
      Add support for building lxml on pre-release Pythons.
      Mark failing tests as xfail. Ref #4864.
      Remove Python version gate in _make_strs.
      Remove _make_strs and update msvc to accept WindowsPath.
      Always rewrite a Python shebang to #!python.
      👹 Feed the hobgoblins (delint).
      Reword note.
      Bump version: 75.8.2 → 75.9.0
      Add news fragment.
      In config command, move to eager imports. Restore LinkError to ccompilers module.
      Add news fragment.
      Remove more lazy imports.
      Bump version: 75.9.0 → 75.9.1
      Bump version: 75.9.1 → 76.0.0
      Clean up docstring.
      Merge pull request #4766 from di/fix/3777
      Repoint the news fragment.
      Bump version: 75.3.0 → 75.3.1
      Pin ruff at 2024-10-29 to avoid emergent failures from later releases.
      Mark failing tests as xfail. Ref #4864.
      Mark failing test as xfail.
      Add a news entry.
      Bump version: 75.3.1 → 75.3.2
      Add test capturing missed expectation.
      Calculate host_id in one expression.
      Add news fragment.
      Restore implicit expectation that importing unixccompiler makes distutils.ccompiler available.
      Fix reference in changelog.
      Bump version: 76.0.0 → 76.1.0

Marc Mueller (16):
      Store license-files in licenses subfolder
      Update validate-pyproject to 0.23.0
      Adjust test example
      Use os.sep for replace
      Add initial support for License-Expression (PEP 639)
      Additional test case
      Normalize license expression
      Remove License-Expression field
      Review
      Replace error with warning and remove license classifier
      Revert removing the license classifier
      Bump core metadata version to 2.4
      Deprecate tools.setuptools.license-files
      Suggestions
      Fix reference
      Update link in userguide

Scott Talbert (1):
      setuptools.msvc: set host_dir correctly on ARM64 hosts

shenxianpeng (4):
      Fix TODO comments and typos
      Fix more typos
      Revert remove TODO comment code
      Revert change files under _vendor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in CI for cygwin

3 participants