Merged
Conversation
abravalheri
approved these changes
Oct 31, 2024
Contributor
abravalheri
left a comment
abravalheri
left a comment
There was a problem hiding this comment.
Thank you very much.
| _traceback: object, | ||
| _exc_type: type[BaseException] | None, | ||
| _exc_value: BaseException | None, | ||
| _traceback: TracebackType | None, |
Contributor
There was a problem hiding this comment.
I have the impression that these might have been oscillating between the 2 forms between PRs.
Contributor
Author
There was a problem hiding this comment.
Yeah at one point I forgot I can't have a protocol or base classe declare its params as "unused" otherwise all subclasses/implementations must as well to respect the LSP.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Syncing types updates and improvements from typeshed following #4504
Pull Request Checklist
newsfragments/.(See documentation for details)