Statically alias distutils-stubs to setuptools._distutils#4704
Draft
Statically alias distutils-stubs to setuptools._distutils#4704
Conversation
This was referenced Oct 25, 2024
Closed
Avasam
commented
Oct 25, 2024
1733d12 to
f950ecc
Compare
7085815 to
e66c7ae
Compare
Contributor
Author
|
I've added a comment at the top of geenrated files to make it clear that they are generated and how to regenerate them. |
Avasam
commented
Nov 25, 2024
Avasam
commented
Nov 25, 2024
4ed7925 to
5b9d787
Compare
5b9d787 to
0f98b7e
Compare
Avasam
commented
Feb 24, 2025
2 tasks
Contributor
Author
|
I'm currently putting my efforts towards #4861 as a solution. Which does the same thing, but autogenerates the stubs on install/wheel creation instead of having them being checked in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes #4689
This is an alternative to #4691. This makes type-checkers and editors see
distutilsas basically an alias tosetuptools.Advantage:
Disadvantage:
setuptools._distutilsannotations distutils#329)Pull Request Checklist
newsfragments/. (no need until this is shipped with setuptools)(See documentation for details)