From @abravalheri https://github.com/pypa/setuptools/pull/4505/files#r1709465928

Jason might have added support for PathLikesources recently in pypa/distutils#237 (v72.2.0/setuptools/_distutils/extension.py#L29).

(PS.: granted they are incompatible with SETUPTOOLS_USE_DISTUTILS=stdlib but that is a deprecated code path).

It is likely here that requirements and the return value are both list[str]. Not sure how the type-checking would react to that though...

Doesn't cause any issue. I didn't add annotations to _get_build_requires because it's not typed in typeshed. config_settings param being typed is incidental to adding all _ConfigSettings.

But since you're mentioning it here and it's not an issue, I've added the type annotation to requirements param

I don't feel like this alias brings anything of value:

• It doesn't work around any runtime issue
• It doesn't abstract away any complexity
• It's not clearer than the type it's aliasing, or doesn't help explain it
• It's barely any more concise (because it's using a shorthand instead of being clear and explicit)

In fact, it might actually hurt understandability as a dev can reasonably assume that the alias might be abstracting a more complex type and have to check what it is, rather than immediately understanding it's Iterator[str]

But it's not private. Could we maybe deprecate it ?

I think we can be a bit bold here and replace it directly... people should not be importing StrIter from this module... A search on GitHub seems to indicate they are not: https://github.com/search?q=%2Fsetuptools.discovery.*StrIter%2F&type=code.

(the whole module should have been introduced as a private module... but at that point in time I did not know better).

Either this, or:

• default always_copy to False (I wasn't sure if None was used as a special meaning "not set by user");
• allow install_needed param to be None;
• use a differently named variable in install_item (like _install_needed);

I think we can be a bit bold here and replace it directly... people should not be importing StrIter from this module... A search on GitHub seems to indicate they are not: https://github.com/search?q=%2Fsetuptools.discovery.*StrIter%2F&type=code.

(the whole module should have been introduced as a private module... but at that point in time I did not know better).

        level: object = 1,

This one looks odd, but I suppose that is because it assumes either int or boolean values elsewhere.

object can be used to mean "any parameter type" for unused params, (Typeshed has the alias _typeshed.Unused), but that might lead to LSP violations since subclasses should now support any object.

I should maybe change it to int (Unless you tell me that subclasses of these classes should not support an "optimization level" a depth level on this method)

Edit: uh that probably represent a depth level, not optimization ^^" Anyway, it's currently unused all the way down to the base Command class in distutils.

I'll need to go fix it in typeshed first (or #4689) I'll leave it "as-is" for this PR. You can squash-merge the whole thing once green.

Thank you @Avasam, once the CI finishes running I will squash it.