Skip to content

Support PEP 625#4286

Merged
jaraco merged 7 commits intopypa:mainfrom
di:fix/3593
Apr 12, 2024
Merged

Support PEP 625#4286
jaraco merged 7 commits intopypa:mainfrom
di:fix/3593

Conversation

@di
Copy link
Copy Markdown
Member

@di di commented Mar 20, 2024

Summary of changes

Support PEP 625 by canonicalizing package name and version in filenames.

Closes #3593.

Pull Request Checklist

@di
Copy link
Copy Markdown
Member Author

di commented Mar 20, 2024

Hmm, the failing test doesn't fail for me locally.

@di
Copy link
Copy Markdown
Member Author

di commented Mar 20, 2024

Looks like it's because this job is testing against stdlib distutils and not vendored distutils? What's the right path forward here?

Copy link
Copy Markdown
Contributor

@abravalheri abravalheri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution, @di!

I left some comments about the specific implementation.

Maybe @jaraco would like to have a look on the PR regarding the name normalisation?

Comment thread setuptools/_distutils/dist.py Outdated
@di
Copy link
Copy Markdown
Member Author

di commented Mar 21, 2024

@abravalheri Thanks! Everything is passing now.

@abravalheri abravalheri requested a review from jaraco April 4, 2024 09:12
Comment thread setuptools/dist.py Outdated
Comment thread setuptools/dist.py Outdated
@jaraco jaraco self-assigned this Apr 11, 2024
Comment thread setuptools/tests/test_config_discovery.py Outdated
Comment thread setuptools/dist.py Outdated
Comment thread setuptools/tests/test_config_discovery.py
Comment thread setuptools/dist.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FR] Implement PEP 625 - File Name of a Source Distribution

4 participants