Skip to content

add pypy schemas to command/install.py#2221

Merged
jaraco merged 2 commits intopypa:distutilsfrom
mattip:pypy
Jul 2, 2020
Merged

add pypy schemas to command/install.py#2221
jaraco merged 2 commits intopypa:distutilsfrom
mattip:pypy

Conversation

@mattip
Copy link
Copy Markdown
Contributor

@mattip mattip commented Jun 28, 2020

Summary of changes

This is a start: there are still 3 pypy failures after this change.
I think they are related to sysconfig specifically finding Python.h, and one may be a bad test.

@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Jun 28, 2020

pytest-cov makes the tests run too slow, can we disable it for PyPy?

@pganssle
Copy link
Copy Markdown
Member

pytest-cov makes the tests run too slow, can we disable it for PyPy?

I haven't looked at the rest of the PR, but I think we originally did skip coverage for PyPy because of the speed issue. Not sure why that changed — possibly it was only in the Travis configuration and didn't make the leap over to GHA?

@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Jul 2, 2020

@jaraco now that pypa/distutils#1 is merged, will a PR to merge that distutils version replace this PR? Should I close this?

@mattip
Copy link
Copy Markdown
Contributor Author

mattip commented Jul 2, 2020

Note the CI changes here are still needed to skip coverage testing for PyPy.

@jaraco
Copy link
Copy Markdown
Member

jaraco commented Jul 2, 2020

Good question. I skipped the PR, but merged the distutils changes in 7a8c226 and rebased the other commits. I'll review these changes separately.

@jaraco
Copy link
Copy Markdown
Member

jaraco commented Jul 2, 2020

In #2224, I've simplified the coverage configuration some. I think that addresses the one commit. I plan to merge the other commits. Thanks so much!

@jaraco jaraco merged commit c486771 into pypa:distutils Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants