Skip to content

Generate doc previews for pull requests#1367

Merged
jaraco merged 1 commit into
pypa:masterfrom
jmbowman:jmbowman/doc_previews
May 16, 2018
Merged

Generate doc previews for pull requests#1367
jaraco merged 1 commit into
pypa:masterfrom
jmbowman:jmbowman/doc_previews

Conversation

@jmbowman

Copy link
Copy Markdown
Contributor

Summary of changes

Tell Netlify how to build and publish the documentation preview for each pull request.

Pull Request Checklist

  • News fragment added in changelog.d. See documentation for details

@jaraco

jaraco commented May 16, 2018

Copy link
Copy Markdown
Member

@ewdurbin In reviewing this PR, I seem to be unable to manage the netlify config for this project. When I log into netlify with my GitHub account, I'm not prompted to select any organization, and no projects are listed. Can you confirm that Setuptools Developers has access to administer the netlify site for Setuptools? Thanks.

@jmbowman jmbowman closed this May 16, 2018
@jmbowman jmbowman reopened this May 16, 2018
@pganssle

Copy link
Copy Markdown
Member

Is there supposed to be a build hook in the PR that links to the new documentation? How do we see the newly built docs?

@jmbowman

Copy link
Copy Markdown
Contributor Author

We're still sorting out the Netlify settings, but once done it should show up as one of the status checks alongside AppVeyor and Travis-CI.

@jmbowman
jmbowman force-pushed the jmbowman/doc_previews branch from ad29abc to 7326ff2 Compare May 16, 2018 16:11
@jmbowman

Copy link
Copy Markdown
Contributor Author

That test has failed in AppVeyor before:

I can take a stab at making it more reliable, but it seems like that should be in a separate PR.

Otherwise, working! See the "Details" link in the "deploy/netlify" job for the output.

@jaraco
jaraco merged commit 1252d1b into pypa:master May 16, 2018
@jmbowman
jmbowman deleted the jmbowman/doc_previews branch May 16, 2018 20:37
@jaraco jaraco mentioned this pull request May 24, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants