Pull out high-level interfaces as an extended example#83
Merged
Conversation
Member
|
Suggestion: move it into examples/*, to clearly denote that it's an example and make room for us to add additional things/examples/demos if we want to in the future. |
Member
Author
|
OK, I've moved it into an |
pradyunsg
approved these changes
Aug 30, 2020
Member
Author
|
Thanks @pradyunsg :-) |
Member
|
How do we plan to manage the rollout of this change? There's probably a fair number of folks using this as a CLI tool. |
Member
|
I'd probably wait until a new python-build release/python-build gets into PyPA, so that we can recommend that as an alternative. |
Member
|
@FFY00 any ETA on that? anything to help with that? |
Member
|
I need to fix some simple issues and probably improve the test suite a bit. I don't think it should take too long. |
Member
|
Am I correct in understanding that this removes I guess I should have taken more seriously the warnings that it wasn't necessarily ready for production use, but given that this was the only PEP 517 build front-end for several years, I would kind of expect it to keep working at least for a while. I'll now have to run around and pin the versions on a bunch of my projects now. If the justification is "we'll get a release of |
pganssle
added a commit
to pganssle/zoneinfo
that referenced
this pull request
Sep 8, 2020
The high level CLI will evidently be removed soon (and suddenly): pypa/pyproject-hooks#83
pganssle
added a commit
to python/tzdata
that referenced
this pull request
Sep 8, 2020
pep517 will apparently soon drop the pep517.build CLI, suddenly. No replacement is available, so we will pin to the latest version that supports it. pypa/pyproject-hooks#83
rmorshea
added a commit
to reactive-python/reactpy
that referenced
this pull request
Sep 12, 2020
rmorshea
added a commit
to reactive-python/reactpy
that referenced
this pull request
Sep 12, 2020
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 14, 2020
This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 14, 2020
This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83
matthewfeickert
added a commit
to matthewfeickert/heputils
that referenced
this pull request
Sep 15, 2020
* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83 * Remove check stage as done implicitly with python-build - c.f. https://github.com/FFY00/python-build/issues/105
kratsg
pushed a commit
to scikit-hep/pyhf
that referenced
this pull request
Sep 15, 2020
* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83 * Remove check stage as done implicitly with python-build - c.f. https://github.com/FFY00/python-build/issues/105
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 15, 2020
This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83
henryiii
added a commit
to henryiii/pybind11
that referenced
this pull request
Sep 15, 2020
This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83
henryiii
added a commit
to pybind/pybind11
that referenced
this pull request
Sep 16, 2020
* feat: setup.py redesign and helpers * refactor: simpler design with two outputs * refactor: helper file update and Windows support * fix: review points from @YannickJadoul * refactor: fixes to naming and more docs * feat: more customization points * feat: add entry point pybind11-config * refactor: Try Extension-focused method * refactor: rename alt/inplace to global * fix: allow usage with git modules, better docs * feat: global as an extra (@YannickJadoul's suggestion) * feat: single version location * fix: remove the requirement that setuptools must be imported first * fix: some review points from @wjacob * fix: use .in, add procedure to docs * refactor: avoid monkeypatch copy * docs: minor typos corrected * fix: minor points from @YannickJadoul * fix: typo on Windows C++ mode * fix: MSVC 15 update 3+ have c++14 flag See <https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-standard-version?view=vs-2019> * docs: discuss making SDists by hand * ci: use pep517.build instead of manual setup.py * refactor: more comments from @YannickJadoul * docs: updates from @ktbarrett * fix: change to newly recommended tool instead of pep517.build This was intended as a proof of concept; build seems to be the correct replacement. See pypa/pyproject-hooks#83 * docs: updates from @wjakob * refactor: dual version locations * docs: typo spotted by @wjakob
dguest
pushed a commit
to dguest/pandamonium
that referenced
this pull request
Sep 22, 2020
* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83 * Remove check stage as done implicitly with python-build
matthewfeickert
added a commit
to scikit-hep/pylhe
that referenced
this pull request
Sep 22, 2020
* Migrate from the deprecated pep517.build to python-build CLI for builds for packaging - c.f. pypa/pyproject-hooks#83
thiagokokada
added a commit
to thiagokokada/i3pyblocks
that referenced
this pull request
Sep 27, 2020
pep517.build is going to be deprecated: pypa/pyproject-hooks#83 So let's use a tool that explicitly has an interface we can use to build.
3 tasks
webknjaz
added a commit
to ansible/pylibssh
that referenced
this pull request
Apr 13, 2021
This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91
webknjaz
added a commit
to ansible/pylibssh
that referenced
this pull request
Apr 13, 2021
This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91
webknjaz
added a commit
to ansible/pylibssh
that referenced
this pull request
Apr 13, 2021
This is necessary because `pep517` is going to drop its experimental CLIs eventually and the PyPA recomments using a new tool called `build` instead. `pypa/build` is a CLI built around the APIs provided by the `pep517` library. Refs: * pypa/pyproject-hooks#83 * pypa/pyproject-hooks#91
Pastidio0924
added a commit
to Pastidio0924/reactpy
that referenced
this pull request
Apr 2, 2025
Pastidio0924
added a commit
to Pastidio0924/reactpy
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An attempt to tackle #82, by putting all the code that tries to manage environments & installation into a separate
buildtool_demopackage, which does not get installed.This will break things for anyone who was relying on the high-level functionality being in
pep517, but I don't see any way to clean it up without doing that.The functions for loading & checking the build-system info are retained as part of the real package, in
pep517.pyproject.