Merged
Conversation
Member
Author
|
I verified the fix by testing it against Setuptools, which encountered #140 in pypa/setuptools#3365 (comment). |
Member
Author
|
Also, tests pass where they fail without the patch: |
Member
Author
|
Please let me know if you won't be able to cut a release with this or a similar fix in the next couple of weeks. If not, I'll probably need to suppress these errors or pin to github for the code. |
Member
Author
|
@pfmoore or @takluyver - any feedback on this change? I'd really prefer to get a release of it rather than have a multi-phase suppress/allow across all of my projects. |
Member
|
It seems OK to me. |
pradyunsg
approved these changes
Jun 27, 2022
Member
Author
|
I've gone ahead and prepared the 0.13 release to get this fix out. |
This was referenced Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140