Skip to content

Drop Python 3.7#1005

Merged
dukecat0 merged 5 commits intopypa:mainfrom
chrysle:drop-3.7
Nov 15, 2023
Merged

Drop Python 3.7#1005
dukecat0 merged 5 commits intopypa:mainfrom
chrysle:drop-3.7

Conversation

@chrysle
Copy link
Copy Markdown
Contributor

@chrysle chrysle commented Jun 19, 2023 •
edited
Loading

  • I have added an entry to docs/changelog.md

Summary of changes

Dropped support for Python 3.7 which is EOL on June 26, 2023.

Closes #1040

Test plan

Tested by running

# command(s) to exercise these changes

@chrysle chrysle changed the title Drop 3.7 Drop Python 3.7 Jun 19, 2023
@zanieb zanieb mentioned this pull request Jun 27, 2023
Closed
3 tasks
@DimitriPapadopoulos
Copy link
Copy Markdown
Contributor

DimitriPapadopoulos commented Aug 13, 2023

I would recommend changing this too:

pipx/src/pipx/__init__.py

Lines 3 to 8 in 238ae43

if sys.version_info < (3, 6, 0):
sys.exit(
"Python 3.6 or later is required. "
"See https://github.com/pypa/pipx "
"for installation instructions."
)

@DimitriPapadopoulos DimitriPapadopoulos mentioned this pull request Aug 13, 2023
Closed
@chrysle
Copy link
Copy Markdown
Contributor Author

chrysle commented Aug 13, 2023

I would recommend changing this too

Thanks, but I already did that.

@dukecat0
Copy link
Copy Markdown
Member

dukecat0 commented Oct 6, 2023

We may also need to remove this:

pipx/pyproject.toml

Line 27 in b489691

"importlib-metadata>=3.3.0; python_version < '3.8'",

@dukecat0
Copy link
Copy Markdown
Member

dukecat0 commented Nov 14, 2023

@chrysle I think it's time to merge this. Could you apply the above comment and resolve the conflict?

@chrysle
Copy link
Copy Markdown
Contributor Author

chrysle commented Nov 14, 2023

@chrysle I think it's time to merge this. Could you apply the above comment and resolve the conflict?

Sure, done!

@dukecat0 dukecat0 merged commit aa5e940 into pypa:main Nov 15, 2023
@chrysle chrysle deleted the drop-3.7 branch November 15, 2023 15:23
@MrLixm MrLixm mentioned this pull request May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dukecat0 dukecat0 dukecat0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Python 3.6 or later is required."

3 participants

@chrysle @DimitriPapadopoulos @dukecat0