Should I ignore these tests? They should not be failing.

These tests failed.

1. def test_https_dependency_links_install(self, PipenvInstance, pypi): in pipenv\tests\integration\test_install_twists.py
   https://github.com/pypa/pipenv/blame/master/tests/integration/test_install_twists.py#

2. def test_complex_deps_lock_and_install_properly(PipenvInstance, pip_src_dir, pypi): in pipenv\tests\integration\test_lock.py
   https://github.com/pypa/pipenv/blame/master/tests/integration/test_lock.py#

Windows CI-
https://dev.azure.com/pypa/pipenv/_build/results?buildId=4833&view=ms.vss-test-web.build-test-results-tab

Linux CI
https://dev.azure.com/pypa/pipenv/_build/results?buildId=4834&view=ms.vss-test-web.build-test-results-tab

in 1. this -> git+https://github.com/atzannes/[email protected]#egg=test-private-dependency-v0.1 might be the issue. https://github.com/atzannes/test-private-dependency/blob/master/README.md says git+ssh

Trying this on my machine->

git clone git+https://github.com/atzannes/[email protected]#egg=test-private-dependency-v0.1
Cloning into '[email protected]#egg=test-private-dependency-v0.1'...
fatal: unable to find remote helper for 'git+https'

This works->

git clone git://github.com/atzannes/test-private-dependency.git
git clone https://github.com/atzannes/test-private-dependency.git

Let me know what to do about this.

Should failing tests be ignored? Maybe I should create a 2nd pull to fix these 9 tests as they seem to be the same for -

#3536
#3555
which should pass. They are trivial changes.

Getting issues with dev environ again. This is one reason its so annoying to do this. Thanks to a part in https://pipenv.readthedocs.io/en/latest/dev/contributing/#run-the-tests

Fix this first?

@snow8gaia Thanks for your efforts, we are not going to look at PRs until the CI issue is fixed. You can wait for it and just ignore the failures before it's done. #3298

frostming Thanks for the update.

#3298 is merged. Sync the fork ->2 failing.

https://dev.azure.com/pypa/pipenv/_build/results?buildId=5560 -> the commit 0984bab

the function def test_install_does_not_extrapolate_environ(PipenvInstance, pypi) in https://github.com/pypa/pipenv/blame/0984bab787158d6bb174e54876ab45f084dee960/tests/integration/test_install_basic.py#

frostming Ignore the failing tests, got it. So, I will begin working on this. (hope that's what you meant by 'you can wait for it and ignore the failures before it's done')

Based on https://pipenv.readthedocs.io/en/latest/dev/contributing/#steps-for-submitting-code

Step2

• Run the tests locally.
  Tests fail. So use the CI checking this PR to say- passed all tests. Ignore tests.
  Step2.1
• All tests pass before any changes are made.

Step3

• Write tests that demonstrate your bug or feature.
• Ensure that they fail.
  ok. on it.

Step4
- [ ] Discuss approach to solve it?
or

• Code then discuss?

All checks pass.

this PR doesn't appear to carry any changes with it. You don't need to rely on tests that are not related to the changes you are attempting to make but please don't open dummy PRs as a personal workbench. Do feel free to open a work in progress PR when you have some working code for review

Closing this for now as it currently contains no changes

Seen.

Sorry for noupdates, delay, etc. permanently set my GitHub status to Busy.

1. Is 'issue Warn about invalid extras during locking #3343' already fixed?
   Anyways, I wrote some code, I think it works. Its in pipenv\core.py in def do_lock() -

  # warn about invalid extras in Pipfile
  from .environment import Environment
  for section in pipfile_section:
      for k,v in pipfile[section].copy().items():
          if hasattr(v, "extras"):
              if k =! package__name.valid and package__name.is_installed(k):# check if extra is valid
                  raise exceptions.PipenvFileError(message="Invalid extra in Pipfile in [{0}] section".format(
                                  pipfile_section.replace("_", "-")))

2. Can this same PR be re-opened? I can't push my fork since some time.
   Thanks.

will try to reply quickly.

@snow8gaia We don't keep PRs without any meaningful change and just for personal testing.

If you have some working code you can push it to your fork repo and open another PR. Closing a PR won't cause you unable to push.

1. Got any ideas for personal testing?

2. while syncing the local copy of the fork, commits are generated. Can't push them since the PR got closed. I'll try pushing it again.

edit:

git add pipenv/core.py
git push origin master

Thanks a lot frostming. It works now. Earlier I hadn't added any code to the repo. Whenever I would sync the fork and then try to update the fork by 'git push origin master'. It would give this error message-

To https://github.com/snow8gaia/pipenv.git
 ! [rejected]          master -> master (fetch first)
error: failed to push some refs to 'https://github.com/snow8gaia/pipenv.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

edit2:
Here's the udpated repo link https://github.com/snow8gaia/pipenv. Its 8 commits ahead of pipenv.

1. In your previous comment did you mean that the code snippet does not work? Or something else?
2. I have not committed the above snippet to the fork yet.

I Will be gone for a while.

I have not committed the above snippet to the fork yet.

yeah it only contains updates of this PR for now. In case the remote repo rejects your push you need to do git pull origin master first to merge the changes you don't have in your local copy, then push will be fine.

It will be better if you can squash the commits without changes.

1. Assuming squash means-> combine multiple commits that sync fork with pypa/pipenv.
   not what I wanted -> master...snow8gaia:master

2. if getattr(v, "extra") is not in project.installed_package_names: from
   2026085

3. hope 1&2 are fun. smiley emoji.

4. i'll make a 'Pull request' soon.

I will be gone for a while.

As far as I know, #3343 is not complete. I quit, i.e. not working on it anymore.
from creation of issue #3343: About 159 days ( 5 months, 1 week, 1 day )
Feel free to ask anything.