Simplify an interestingly written conditional #7161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
reviewed
Oct 7, 2019
src/pip/_internal/utils/misc.py
Outdated
| @@ -569,8 +569,6 @@ def egg_link_path(dist): | |||
| if running_under_virtualenv(): | |||
| if virtualenv_no_global(): | |||
There was a problem hiding this comment.
Suggested change
| if virtualenv_no_global(): | |
| if not virtualenv_no_global(): |
|
Both ways do not pass the tests, since either in a yes-global venv or in a no-global venv, nothing is actually appended. if running_under_virtualenv():
sites.append(site_packages)
if not virtualenv_no_global() and user_site:
sites.append(user_site)That way the logic actually matches the description in the docstring and tests pass. |
|
Sounds like a plan! |
added 4 commits
October 8, 2019 10:15
pradyunsg
added
the
skip news
pradyunsg
changed the title
|
Thanks @kmoza and @deppiedave64! ^>^ |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.