Create new module: network.auth #7045
Conversation
chrahunt
added
type: refactor
|
nit: let's call the sub-package network? That'd be consistent with the rest of the sub-package names, none of which use the "ing" form of verbs. (I just woke up so my brain isn't giving me fancy grammar words) |
chrahunt
force-pushed
the
refactor/networking
branch
from
33a329f to
777810e
Compare
chrahunt
force-pushed
the
refactor/networking
branch
from
777810e to
7e1d022
Compare
|
Reopening for Appveyor... (may have done it too soon, it was probably just queued) |
pradyunsg
changed the title
| @@ -0,0 +1,289 @@ | |||
| import logging | |||
There was a problem hiding this comment.
Let's add a doc-string to the module describing what all is happening in it and what we expect would be used by "consumers" of the module.
In general, when we're adding new modules as a result of breaking up existing modules, we should do this so that it makes our lives easier 6 months later when we forget how exactly we'd split the functionality. :)
There was a problem hiding this comment.
Sure. I'll create a follow-up PR later today.
lock
bot
added
the
auto-locked
The first of a handful of modules that can go into this package to split out the "pure" parts of
pip._internal.download.