Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate NEWS files with rstcheck. #7027

Merged
merged 1 commit into from
Sep 20, 2019

Conversation

chrahunt
Copy link
Member

@chrahunt chrahunt commented Sep 17, 2019

Now we call rstcheck via nox, and check on push/PR with GitHub actions.

Closes #5207.

@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Sep 17, 2019
@chrahunt chrahunt marked this pull request as ready for review September 17, 2019 01:46
@pradyunsg
Copy link
Member

nit: atomic commits - split the move of the template into a separate commit, before introducing rstcheck.

@chrahunt
Copy link
Member Author

I'll leave it as is and give the CI a break this time, but will keep that in mind.

@chrahunt chrahunt merged commit 67856e3 into pypa:master Sep 20, 2019
@chrahunt chrahunt deleted the maint/validate-news branch September 20, 2019 16:14
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check news fragments to confirm they are valid ReST
2 participants