Only show Python 2.7 EOL date on CPython.#6208
Conversation
gaborbernat
left a comment
gaborbernat
left a comment
There was a problem hiding this comment.
Looks good, @pradyunsg @dstufft @pfmoore however given that most users are stuck on Python 2 because of their system limitations, not their personal choice, maybe we should drop the message entirely. Guido seems to agree towards this too.
|
So as I mentioned on the other issue, in case my vote counts :), assuming pip has no concrete plans to drop Py2 support, I'd personally:
with the reasoning being that whether they like it or not, users using CPython do need to consider EOL (whether pip is the right thing to warn about that who knows, which maybe is the argument to drop it entirely, but I hope something does show one...) Users using PyPy (well me) do not need to worry about EOL, there isn't one, and our support is continuing for now. If |
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
LGTM.
Will include in 19.0.2.
cjerdonek
left a comment
cjerdonek
left a comment
There was a problem hiding this comment.
Can a .bugfix news file be added since this is a user-visible change, and I think the distinction is worth highlighting in the release notes?
Other Python implementations, notably PyPy, are not EOL'ing on January 1, 2020.
Julian
force-pushed
the
python27-warning
branch
from
e0f9386 to
77c989f
Compare
|
@cjerdonek done |
I'm inclined to add an option and suggest in the message how to suppress the message itself, using |
@pradyunsg Is it okay to discuss this in a separate issue / PR so this can be merged? |
Yea, definitely. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
Bot
added
the
auto-locked
4 participants
Other Python implementations, notably PyPy, are not EOL'ing on January
1, 2020.
I've left the core of the warning intact, and have just found https://discuss.python.org/t/packaging-and-python-2/662/73 about pip's own plans (obviously my hope would be that pip does continue to support py2, but will follow that along).
Closes: #6207