Show time taken to download instead of eta 0:00:00 in Rich Progress#13486
Merged
Show time taken to download instead of eta 0:00:00 in Rich Progress#13486
eta 0:00:00 in Rich Progress#13486Conversation
added 2 commits
July 18, 2025 08:03
Member
|
Thanks for your PR to pip. Please be aware all maintainers are volunteers so it may take a moment for someone to review. That said, let me know if you need any help fixing the the linting and pre-commit errors, you should be able to locally run them following this guide: https://pip.pypa.io/en/stable/development/getting-started/#running-linters |
pradyunsg
approved these changes
Jul 19, 2025
Closed
ichard26
approved these changes
Jul 26, 2025
Member
ichard26
left a comment
ichard26
left a comment
There was a problem hiding this comment.
There is an extra space, but there isn't much we can do about that unfortunately. It'd be nice if Rich wouldn't add the space if the column was empty, but looking at the codebase, such a change seems nontrivial.
Member
|
Thank you @qraqras for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #13483
Thanks!